Re: [PATCH] mfd/mc13783: near complete rewrite

[Uwe Kleine-König]

Hi Mark,

On Mon, Nov 02, 2009 at 02:09:25PM +0000, Mark Brown wrote:
> On Mon, Nov 02, 2009 at 02:58:27PM +0100, Uwe Kleine-K?nig wrote:
> > On Mon, Nov 02, 2009 at 11:51:01AM +0000, Mark Brown wrote:
> 
> > > This might create issues with a request_nounmask() function, though a
> > > request plus mask is probably enough - I guess you're using this for
> > > your the RTC driver in which case a spurious periodic interrupt is
> > > unlikely to be an issue.
> 
> > Yes, I use it to simplify things in the RTC driver a bit.  I register
> > the 1HZ irq unconditionally and only track if it's masked or not.  This way
> > I can save some case discrimination.
> 
> What I've done for wm8350 is just request the IRQ then immediately mask
> it and not worry about a periodic notification coming in in the gap -
> reporting the extra periodic notification is vanishingly unlikely to do
> any harm in the case that the race does crop up.
On mc13783 the 1HZ irq triggers immediately after unmasking provided
that it has power for more than 1s.  Because of locking the irq isn't
recognized as 1HZ as the irqhandler tries to take the lock that the rtc
probe function is holding and only releasing after the irq is masked.
So for me it's just a spurious irq.

Best regards
Uwe

-- 
Pengutronix e.K.                              | Uwe Kleine-König            |
Industrial Linux Solutions                    | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/