Re: [PATCH] pci: remove pci_find_slot from PCI_LEGACY configdescription

From: Alex Chiang
Date: Mon Nov 02 2009 - 13:27:19 EST


* Thadeu Lima de Souza Cascardo <cascardo@xxxxxxxxxxxxxx>:
> On Mon, Nov 02, 2009 at 04:49:01PM +0100, Jiri Kosina wrote:
> > On Fri, 30 Oct 2009, Thadeu Lima de Souza Cascardo wrote:
> >
> > > Commit 3b073eda has removed pci_find_slot, so there's no point in
> > > mentioning it in the config description as one of the deprecated APIs
> > > there are enabled by PCI_LEGACY and still used by some drivers.
> >
> > While you are at it, how about removing the references in
> > Documentation/PCI/pci.txt as well?
>
> I've hit them. But, on a first fast look, they seemed important
> historically. I will take a closer look and point that if it's proper or
> remove them entirely as you suggest.

I think you can safely remove the references to the APIs that are
no longer in the kernel at all, such as pci_find_slot(), etc.

On the other hand, if an interface is still there but deprecated,
you can leave it in Documentation/PCI/pci.txt.

Thanks,
/ac

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/