[PATCH 18/20] blkio: arm idle timer even if think time is great then time slice left

From: Vivek Goyal
Date: Tue Nov 03 2009 - 18:44:35 EST


o Now we plan to wait for a queue to get backlogged before we expire it. So
we need to arm slice timer even if think time is greater than slice left.
if process sends next IO early and time slice is left, we will dispatch it
otherwise we will expire the queue and move on to next queue.

Signed-off-by: Vivek Goyal <vgoyal@xxxxxxxxxx>
---
block/cfq-iosched.c | 9 ---------
1 files changed, 0 insertions(+), 9 deletions(-)

diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index b7ef953..963659a 100644
--- a/block/cfq-iosched.c
+++ b/block/cfq-iosched.c
@@ -1702,15 +1702,6 @@ static bool cfq_arm_slice_timer(struct cfq_data *cfqd, int reset)
if (!cic || !atomic_read(&cic->ioc->nr_tasks))
return false;

- /*
- * If our average think time is larger than the remaining time
- * slice, then don't idle. This avoids overrunning the allotted
- * time slice.
- */
- if (sample_valid(cic->ttime_samples) &&
- (cfqq->slice_end - jiffies < cic->ttime_mean))
- return false;
-
cfq_mark_cfqq_wait_request(cfqq);

/*
--
1.6.2.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/