Re: [PATCH testing] Do not call IPv4 specific func in tcp_check_req

[David Miller]

From: Gilad Ben-Yossef <gilad@xxxxxxxxxxxxxxx>
Date: Wed,  4 Nov 2009 18:40:54 +0200

> Calling IPv4 specific inet_csk_route_req in tcp_check_req
> is a bad idea and crashes machine on IPv6 connections, as reported
> by Valdis Kletnieks
> 
> Also, all we are really interested in is the timestamp
> option in the header, so calling tcp_parse_options()
> with the "estab" set to false flag is an overkill as
> it tries to parse half a dozen other TCP options.
> 
> We know whether timestamp should be enabled or not
> using data from request_sock.
> 
> Signed-off-by: Gilad Ben-Yossef <gilad@xxxxxxxxxxxxxxx>

Applied, thanks.

I assume that your other patch which attempted to fix this isn't
necessary.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/