Re: [PATCH] pci/pcie: Avoid unnecessary PCIe link retrains

[Kenji Kaneshige]

Matthew Wilcox wrote:
> On Thu, Nov 05, 2009 at 12:05:11PM +0900, Kenji Kaneshige wrote:
> > There are a lot of codes that searches PCI express capability offset
> > in the PCI configuration space using pci_find_capability(). Caching it
> > in the struct pci_dev will reduce unncecessary search. This patch adds
> > an additional 'pcie_cap' fields into struct pci_dev, which is
> > initialized at pci device scan time (in set_pcie_port_type()).
>
> I think adding this should imply the removal of ->is_pcie.  pcie_cap == 0
> means !is_pcie.

Right.

But, as you know, we need to change users of is_pcie (including some
adapter card drivers) before removing it.

Thanks,
Kenji Kaneshige


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/