Re: [PATCH v10 1/1] virtio_console: Add support for multiple ports for generic guest and host communication

[Christian Borntraeger]

Am Dienstag 03 November 2009 17:38:39 schrieb Amit Shah:

> drivers/char/Kconfig           |    6 +
> drivers/char/virtio_console.c  | 1412 ++++++++++++++++++++++++++++++++++++----
> include/linux/virtio_console.h |   50 ++-
> 3 files changed, 1332 insertions(+), 136 deletions(-)

I have not looked at your last two versions of the patch  since you did not add 
a changelog to your patch description. I thought you only did minor changes.
Turned out you added/changed several places. (e.g. VIRTIO_CONSOLE_CACHE_BUFFERS, 
VIRTIO_CONSOLE_THROTTLE_PORT  and VIRTIO_CONSOLE_BUFFER_LIMIT  are all new)

When you do bigger changes can you add a changelog in your patch description in 
the future?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/