Re: [PATCH] ptrace: copy_thread() should clear TIF_SINGLESTEP andX86_EFLAGS_TF

[Oleg Nesterov]

On 11/06, Roland McGrath wrote:
>
> There is also the TIF_FORCED_TF logic to check.

I thought this flag has no effect without TIF_SINGLESTEP, and it is
always updated by enable_single_step().

> Probably it should just
> call user_disable_single_step() instead.  Perhaps copy_process() should
> just call that and then no per-arch changes would be required.

OK, thanks, will resend tomorrow.

user_disable_single_step() is very much arch-dependent, I am worried
if it is safe to call it from copy_process(), when the new task_struct,
thread_info, etc are not properly initialized yet...

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/