Re: [patch] added brightness feature to lcd class.

From: Pavel Machek
Date: Sat Nov 07 2009 - 11:48:54 EST


On Sat 2009-11-07 21:43:50, InKi Dae wrote:
> Thank you for your comments.
>
> using backlight is good way in case of TFT-LCD Panel.
> because TFT-LCD Panel needs backlight device to light up.
>
> but AMOLED LCD Panel doesn't need backlight device because lighting up itself.

I know. So what?

User wants to set brightness. Why should userspace know/care if it is
TFT or AMOLED?

I have this script:

#!/bin/bash
echo $1 > /sys/class/backlight/*/brightness

why should I have to rewrite it just because you decided amoled is
special?

Kernel is expected to provide hw abstraction...

Pavel


--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/