Re: [PATCH] x86, therm: Only read the initial value of thermal LVTentry on BSP

From: Cyrill Gorcunov
Date: Sun Nov 08 2009 - 08:42:38 EST


[Ingo Molnar - Sun, Nov 08, 2009 at 02:16:55PM +0100]
|
...
|
| > > that makes it cleaner, and also it will work if we dont boot on
| > > cpu==0. (should that ever occur)
| > >
| >
| > May I know when will this happen?
|
| It's not really expected - we factorize the CPU IDs (which are logical)
| so that the boot CPU is 0. But relying on cpu==0 is the boot cpu is not
| clean and the resulting code is harder to read.

Perhaps we need some is_bsp_cpu() helper? Though to cover all x86 places
we need some efforts to apply :/

|
| Ingo
|
-- Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/