Re: [PATCH v4 01/12] vsprintf: factorize "(null)" string

From: Jan Engelhardt
Date: Sun Nov 08 2009 - 10:38:00 EST



Stripping the humongous Cc list for sanity.


On Saturday 2009-11-07 16:16, Andrà Goddard Rosa wrote:

>Change "<NULL>" to "(null)" and make it a static const char[] hoping that
>the compiler will make null_str a label to a read-only area containing it.

Hoping? Nah, thanks.

>See:
>http://udrepper.livejournal.com/13851.html

Ulrich's example already _has_ a variable that is then changed from
const charÂ* to const char[]. Of course doing that will save you the
extra pointer.

But vsprintf.c on the other hand did not have that extra variable to
begin with! But it is ok nevertheless, and the unification of <NULL> vs
(null) is worthwhile.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/