Re: [PATCH -tip] x86,apic: Use PAGE_SIZE instead of numbers

From: Ingo Molnar
Date: Sun Nov 08 2009 - 13:04:00 EST



* Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote:

> [Maciej W. Rozycki - Sun, Nov 08, 2009 at 05:28:05PM +0000]
> | On Sun, 8 Nov 2009, Cyrill Gorcunov wrote:
> |
> | > The whole page is reserved for IO-APIC fixmap
> | > due to non-cacheable requirement. So lets note
> | > this explicitly instead of playing with numbers.
> | >
> | > CC: Yinghai Lu <yinghai@xxxxxxxxxx>
> | > CC: "Maciej W. Rozycki" <macro@xxxxxxxxxxxxxx>
> | > Signed-off-by: Cyrill Gorcunov <gorcunov@xxxxxxxxxx>
> | > ---
> |
> | Acked-by: Maciej W. Rozycki <macro@xxxxxxxxxxxxxx>
> |
> | Is PAGE_SIZE still always 4kB for the x86 these days? If so, then your
> | change makes sense to me.
>
> Yeah, as far as I know. I didn't find any sign if we going to change
> PAGE_SHIFT.

Not in the next 10-20 years or so. (and any prediction beyond that is
pointless i suspect)

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/