Re: [PATCH] ata: Clean up hard coded array size calculation.

From: Thiago Farina
Date: Sun Nov 08 2009 - 14:46:00 EST


On Sun, Nov 8, 2009 at 5:30 PM, Thiago Farina <tfransosi@xxxxxxxxx> wrote:
> Use ARRAY_SIZE macro of kernel api instead.
>
> Signed-off-by: Thiago Farina <tfransosi@xxxxxxxxx>
Reported-by: Robert P. J. Day <rpjday@xxxxxxxxxxxxxx>
> ---
> Âdrivers/ata/sata_mv.c | Â Â2 +-
> Â1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/ata/sata_mv.c b/drivers/ata/sata_mv.c
> index 6f5093b..a8a7be0 100644
> --- a/drivers/ata/sata_mv.c
> +++ b/drivers/ata/sata_mv.c
> @@ -2217,7 +2217,7 @@ static unsigned int mv_qc_issue_fis(struct ata_queued_cmd *qc)
> Â Â Â Âint err = 0;
>
> Â Â Â Âata_tf_to_fis(&qc->tf, link->pmp, 1, (void *)fis);
> - Â Â Â err = mv_send_fis(ap, fis, sizeof(fis) / sizeof(fis[0]));
> + Â Â Â err = mv_send_fis(ap, fis, ARRAY_SIZE(fis));
> Â Â Â Âif (err)
> Â Â Â Â Â Â Â Âreturn err;
>
> --
> 1.6.5.2.150.g1b52a
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/