Re: [PATCH -v5 08/11] tracing: not trace mips_timecounter_init()in MIPS

From: Wu Zhangjin
Date: Mon Nov 09 2009 - 09:44:17 EST


Hi,

On Mon, 2009-11-09 at 07:54 -0500, Steven Rostedt wrote:
[...]
>
> Just do it in the Makefile. We can add __arch_notrace, and then in the
> Makefile define it with the arch.
>
> ifeq ($(ARCH), MIPS)
> CFLAGS_foo.o = -D__arch_notrace=notrace
> endif
>
> And we can simply define __arch_notrace in a header:
>
> #ifndef __arch_notrace
> # define __arch_notrace
> #endif
>
> I much rather uglify the Makefile than the code.
>

Seems can not totally avoid the problem mentioned by Frederic, that is
if there are two many functions in the file, and different platforms
care about different functions ;)

what about Frederic's __time, just replace that __arch_notrace by
__time_notrace, and only consider the time relative functions currently?
Seems this will really make the stuff simpler.

Regards,
Wu Zhangjin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/