Re: [PATCH v5] x86: under bios control, restore AP's APIC_LVTTHMRto the BSP value

[Suresh Siddha]

On Mon, 2009-11-09 at 06:51 -0800, Yong Wang wrote:
>  
> +void mcheck_intel_therm_init(void)
> +{
> +	/*
> +	 * This function is only called on boot CPU. Save the init thermal
> +	 * LVT value on BSP and use that value to restore APs' thermal LVT
> +	 * entry BIOS programmed later
> +	 */
> +	lvtthmr_init = apic_read(APIC_LVTTHMR);
> +}

We shouldn't unconditionally read this LVT entry. We should qualify it
based on the presence of TM1 or TM2 capability, as this LVT entry is
implementation specific and not architectural.

thanks,
suresh 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/