Re: spitz battery driver

From: Pavel Machek
Date: Tue Nov 10 2009 - 08:25:51 EST


k
> > > This is a good move. However, I assume the patch is still RFC now.
> > > Or basically the coding style cleanup can be separated into another
> > > patch?
> >
> > Its rfc now. Parts of codingstyle cleanup should already be in your
> > tree, I'll rediff it later.
>
> Pavel, could you compare your patch with the "power: implement platform
> battery driver"??? patches from Paul Fertser just sent to LKML and
> zaurus-devel list? Would it be complicated to migrate to it? I guess

Complicated? No. Useful? Probably also no. Remove 50 lines for
additional indirection? I'd prefer not to.

> that use of platform driver could allow to recycle major parts of the
> charging driver by more devices.

take a look at those patches. I'd rather use mainline battery api.

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/