Re: [PATCH tip/core/rcu 1/4] rcu: remove inline fromforward-referenced functions

From: Josh Triplett
Date: Tue Nov 10 2009 - 18:20:56 EST


On Tue, Nov 10, 2009 at 01:37:19PM -0800, Paul E. McKenney wrote:
> Some variants of gcc are reputed to dislike forward references to
> functions declared "inline". Remove the "inline" keyword from such
> functions.
>
> Signed-off-by: Paul E. McKenney <paulmck@xxxxxxxxxxxxxxxxxx>
> ---
> kernel/rcutree.h | 2 +-
> kernel/rcutree_plugin.h | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)

Seems very reasonable. For functions declared static and called once, GCC doesn't
really need any help figuring out that it should inline them.

Acked-by: Josh Triplett <josh@xxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/