Re: warn on lookup_one_length/vfs_quota_on_mount

From: Jan Kara
Date: Thu Nov 12 2009 - 11:20:38 EST


Hello,

On Thu 12-11-09 13:42:38, Jan Kara wrote:
> On Thu 12-11-09 08:29:06, Bastien ROUCARIES wrote:
> > I get the following warm on my reiserfs disk with quota enabled at
> > boot (each boot) see
> > http://www.kerneloops.org/raw.php?rawid=937752&msgid=
> > *lookup_one_len
> > ? lookup_one_len
> > ? lookup_one_len
> > ? warn_slowpath_common
> > ? lookup_one_len
> > ? vfs_quota_on_mount
> > ? finish_unfinished
> > ? reiserfs_remount
> > ? __filemap_fdatawrite_range
> > ? do_remount_sb
> > ? do_mount
> > ? sys_mount
> > ? system_call_fastpath
> >
> > But it seems a generic bug in the quota layer due to:
> > http://www.kerneloops.org/oops.php?number=799645
> > http://www.kerneloops.org/oops.php?number=700122
> OK, this shouldn't lead to any real bug (since we look them up during
> filesystem mount or remount read-write when noone can mess with the root
> directory). But it's probably good to silence the warning by proper locking
> anyway. I'll do it. Thanks for the report!
Attached patch fixes the warning for me.

Honza
--
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR