On Thu, 12 Nov 2009, Mike Travis wrote:
I thought dev_dbg needed the 'dev' structure and I wasn't sure how to get--- linux.orig/drivers/acpi/tables.cYou can still use dev_dbg(PREFIX "...") here.
+++ linux/drivers/acpi/tables.c
@@ -66,11 +66,15 @@
{
struct acpi_madt_local_x2apic *p =
(struct acpi_madt_local_x2apic *)header;
- printk(KERN_INFO PREFIX
- "X2APIC (apic_id[0x%02x] uid[0x%02x] %s)\n",
- p->local_apic_id, p->uid,
- (p->lapic_flags & ACPI_MADT_ENABLED) ?
- "enabled" : "disabled");
+ /*
+ * Per cpu tracing clogs console output when NR_CPUS
+ * is large. Send only to kernel log buffer.
+ */
+ printk(KERN_DEBUG PREFIX
+ "X2APIC (apic_id[0x%02x] uid[0x%02x] %s)\n",
+ p->local_apic_id, p->uid,
+ (p->lapic_flags & ACPI_MADT_ENABLED) ?
+ "enabled" : "disabled");
}
break;
that...?
Ah, ok, it needs to be pr_debug(PREFIX "...") then.
Any reason why the other printk's in acpi_table_print_madt_entry() weren't converted to use KERN_DEBUG? It might make more sense to convert all those to use a new acpi=verbose flag.
I'm not sure if Ingo is the right person to go through for acpi patches, I think this should probably be submitted to Len Brown <lenb@xxxxxxxxxx> and linux-acpi@xxxxxxxxxxxxxxx instead.