Re: [tip:x86/debug] x86: Minimise printk spew from per-vendor initcode

From: Dave Jones
Date: Fri Nov 13 2009 - 20:39:30 EST


On Fri, Nov 13, 2009 at 05:03:44PM -0800, Yinghai Lu wrote:

> > --- a/arch/x86/kernel/cpu/common.c
> > +++ b/arch/x86/kernel/cpu/common.c
> > @@ -656,6 +656,7 @@ static void __init early_identify_cpu(struct cpuinfo_x86 *c)
> >
> >  void __init early_cpu_init(void)
> >  {
> > +#ifdef PROCESSOR_SELECT
> >        const struct cpu_dev *const *cdev;
> >        int count = 0;
> >
> > @@ -676,7 +677,7 @@ void __init early_cpu_init(void)
> >                                cpudev->c_ident[j]);
> >                }
> >        }
> > -
> > +#endif
> >        early_identify_cpu(&boot_cpu_data);
> >  }
>
> NACK.
>
> the function is initializing cpu_devs array.

Ugh, I don't know how I missed that. I also seem to have boot tested the wrong kernel.
Back to the drawing board.

Dave



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/