Re: [PATCH] ata: Clean up hard coded array size calculation.

From: Mark Lord
Date: Fri Nov 13 2009 - 22:23:31 EST


Thiago Farina wrote:
On Thu, Nov 12, 2009 at 10:25 PM, Jeff Garzik <jgarzik@xxxxxxxxx> wrote:
On 11/12/2009 06:53 PM, Mark Lord wrote:
Thiago Farina wrote:
On Wed, Nov 11, 2009 at 8:37 PM, Mark Lord <liml@xxxxxx> wrote:
Looks like unnecessary churn and obfuscation to me.
Obfuscation? Are you saying that just because you wrote this code? So
what is the usage of a macro? I think you are having a defensive
position here.
..

No, actually I believe Jeff wrote that particular line of code.
You know, Linus actually invented a command for people who enjoy this
game... ;)

git blame drivers/ata/sata_mv.c

shows each line of code, and metadata about each line such as commit id and
author name.

Sure, and I ran this command before saying that Mark wrote this code.
..

I'm probably just the last chap to change the indentation on it.
It really doesn't look like my style to me. ;)

There were two authors before me there, and that line looks like one of theirs. :)

Cheers
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/