Re: [PATCH -v2 6/9] bootmem: add free_bootmem_late
From: FUJITA Tomonori
Date: Sat Nov 14 2009 - 07:52:29 EST
Thanks for reviewing,
On Tue, 10 Nov 2009 13:00:53 +0100
Johannes Weiner <hannes@xxxxxxxxxxx> wrote:
> I find it a bit weird that free_all_bootmem() callers have to take
> care of totalram_pages while this function does the accounting on its
> own.
Ah, it might be consistent to make the callers take care of
totalram_pages like free_all_bootmem.
> And I think the function is more logically placed right below
> free_bootmem(), like you did in the header.
However, if we do the above, we have:
unsigned long free_bootmem_late(unsigned long addr, unsigned long
size)
Which looks inconsistent a bit with free_bootmem()?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/