Re: Mount -o sync regression in 2.6.31

[Frederic Weisbecker]

On Fri, Nov 13, 2009 at 02:47:27PM -0800, Stephen Hemminger wrote:
> Bisecting between 2.6.30 and 2.6.31-rc1 reduced it down to:
> 
> 8f184f27300f66f6dcc8296c2dae7a1fbe8429c9 is first bad commit
> commit 8f184f27300f66f6dcc8296c2dae7a1fbe8429c9
> Author: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> Date:   Sat May 16 06:24:36 2009 +0200
> 
>     tracing/stat: replace linked list by an rbtree for sorting
>     
>     When the stat tracing framework prepares the entries from a tracer
>     to output them to the user, it starts by computing a linear sort
>     through a linked list to give the entries ordered by relevance
>     to the user.
>     
>     This is quite ugly and causes a small latency when we begin to
>     read the file.
>     
>     This patch changes that by turning the linked list into a red-black
>     tree. Athough the whole iteration using the start and next tracer
>     callbacks while opening the file remain the same, it is now much
>     more fast and scalable.
>     
>     The rbtree guarantees O(log(n)) insertions whereas a linked
>     list with linear sorting brought us a O(n) despair. Now the
>     (visible) latency has disapeared.
>     
>     [ Impact: kill the latency while starting to read a stat tracer file ]
>     
>     Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> 
> Which seems totally out of the path related to this, and no tracing is being done!


The trace stat thing is only used for workqueue profiling,
functions profiling, branch profiling:

CONFIG_WORKQUEUE_TRACER
CONFIG_FUNCTION_PROFILER
CONFIG_PROFILE_ANNOTATED_BRANCHES
CONFIG_PROFILE_ALL_BRANCHES


And none of them seem enabled in your config.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/