Re: [PATCH] x86: Add missing might_fault() fromcopy_{to,from}_user()

[Frederic Weisbecker]

On Mon, Nov 16, 2009 at 04:09:37PM +0100, Ingo Molnar wrote:
> 
> * Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:
> 
> > In x86-64, copy_to/from_user() rely on assembly routines that never
> > call might_fault(), making us missing various lockdep checks.
> > 
> > This doesn't apply to __copy_from,to_user() that explicitly handle
> > these calls, neither is it a problem in x86-32 where
> > copy_to,from_user() rely on the "__" prefixed versions that also call
> > might_fault().
> > 
> > Signed-off-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
> > ---
> >  arch/x86/include/asm/uaccess_64.h |   10 +++++++++-
> >  arch/x86/lib/copy_user_64.S       |    4 ++--
> >  2 files changed, 11 insertions(+), 3 deletions(-)
> 
> Looks good - other than that you missed the renaming of the symbol 
> export line in arch/x86/kernel/x8664_ksyms_64.c, which i fixed.



Oops, sorry!

 
> Thanks,
> 
> 	Ingo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/