Re: [PATCH v2] ALPS: Add support for 4 directions button on AcerAspire 5720

[Maxim Levitsky]

On Sun, 2009-11-15 at 00:53 -0800, Dmitry Torokhov wrote: 
> Hi Maxim,
> 
> On Wed, Nov 11, 2009 at 11:09:50AM +0200, Maxim Levitsky wrote:
> > >From 6b263982ffd62ae4621a5202f0084983af8dc093 Mon Sep 17 00:00:00 2001
> > From: Maxim Levitsky <maximlevitsky@xxxxxxxxx>
> > Date: Wed, 11 Nov 2009 11:03:35 +0200
> > Subject: [PATCH] ALPS: Add support for 4 directions button on Acer Aspire 5720
> >  Implemented using DMI due to uncertainty about systems that have
> >  only the middle button
> > 
> > Signed-off-by: Maxim Levitsky <maximlevitsky@xxxxxxxxx>
> 
> I don't think that we need to do DMI checking. I looked through my mails
> and it looks like all Acers with that signature have 4-directional
> button while Volstro 1400 only has left and right button and so won't be
> affected. Also Synaptics driver treats BTN_0 as BTN_FORWARD and BTN_1
> as BTN_BACK by default so we should still be compatible.
> 
> Could you please try the patch below? It assumes that psmosue core does
> not set up BTN_MIDDLE capability ahead of time though (see a patch
> posted earlier today).
> 
> -- 
> Dmitry
> 
> Input: ALPS - add support for 4 directions button on Acer Aspire 5720
> 
> From: Maxim Levitsky <maximlevitsky@xxxxxxxxx>
> 
> Signed-off-by: Maxim Levitsky <maximlevitsky@xxxxxxxxx>
> Signed-off-by: Dmitry Torokhov <dtor@xxxxxxx>
> ---

Works just fine!

Best regards,
Maxim Levitsky

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/