[PATCH 2/2] perf buildid-list: Always show the DSO name

From: Arnaldo Carvalho de Melo
Date: Mon Nov 16 2009 - 18:45:39 EST


From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>

Porcelain can ignore it, humans can make more sense of it.

Suggested-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>
Suggested-by: Ingo Molnar <mingo@xxxxxxx>
Suggested-by: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Cc: Frederic Weisbecker <fweisbec@xxxxxxxxx>
Cc: Mike Galbraith <efault@xxxxxx>
Cc: Paul Mackerras <paulus@xxxxxxxxx>
Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
Signed-off-by: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
---
tools/perf/Documentation/perf-buildid-list.txt | 2 +-
tools/perf/builtin-buildid-list.c | 2 +-
tools/perf/util/symbol.c | 5 +----
3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/tools/perf/Documentation/perf-buildid-list.txt b/tools/perf/Documentation/perf-buildid-list.txt
index abab34e..01b642c 100644
--- a/tools/perf/Documentation/perf-buildid-list.txt
+++ b/tools/perf/Documentation/perf-buildid-list.txt
@@ -26,7 +26,7 @@ OPTIONS
Don't do ownership validation.
-v::
--verbose::
- Be more verbose, showing the name of the DSOs after the buildids.
+ Be more verbose.

SEE ALSO
--------
diff --git a/tools/perf/builtin-buildid-list.c b/tools/perf/builtin-buildid-list.c
index 2e377e1..7dee9d1 100644
--- a/tools/perf/builtin-buildid-list.c
+++ b/tools/perf/builtin-buildid-list.c
@@ -28,7 +28,7 @@ static const struct option options[] = {
"input file name"),
OPT_BOOLEAN('f', "force", &force, "don't complain, do it"),
OPT_BOOLEAN('v', "verbose", &verbose,
- "be more verbose (show counter open errors, etc)"),
+ "be more verbose"),
OPT_END()
};

diff --git a/tools/perf/util/symbol.c b/tools/perf/util/symbol.c
index 53de9c4..1b77e81 100644
--- a/tools/perf/util/symbol.c
+++ b/tools/perf/util/symbol.c
@@ -1442,10 +1442,7 @@ size_t dsos__fprintf_buildid(FILE *fp)

list_for_each_entry(pos, &dsos, node) {
ret += dso__fprintf_buildid(pos, fp);
- if (verbose)
- ret += fprintf(fp, " %s\n", pos->long_name);
- else
- ret += fprintf(fp, "\n");
+ ret += fprintf(fp, " %s\n", pos->long_name);
}
return ret;
}
--
1.6.2.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/