Re: [PATCH] tracing: prevent build warning: 'ftrace_graph_buf' definedbut not used

From: Lai Jiangshan
Date: Tue Nov 17 2009 - 02:47:11 EST


Frederic Weisbecker wrote:
> On Thu, Nov 05, 2009 at 11:16:17AM +0800, Lai Jiangshan wrote:
>> prevent build warning when !CONFIG_FUNCTION_GRAPH_TRACER
>>
>> Signed-off-by: Lai Jiangshan <laijs@xxxxxxxxxxxxxx>
>
>
> Acked-by: Frederic Weisbecker <fweisbec@xxxxxxxxx>

Hi, Ingo,

Could you apply this cleanup patch for -tip?

Lai

>
>
>
>> ---
>> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
>> index 7cb6f19..892e3ea 100644
>> --- a/kernel/trace/ftrace.c
>> +++ b/kernel/trace/ftrace.c
>> @@ -2274,7 +2274,6 @@ void ftrace_set_notrace(unsigned char *buf, int len, int reset)
>> #define FTRACE_FILTER_SIZE COMMAND_LINE_SIZE
>> static char ftrace_notrace_buf[FTRACE_FILTER_SIZE] __initdata;
>> static char ftrace_filter_buf[FTRACE_FILTER_SIZE] __initdata;
>> -static char ftrace_graph_buf[FTRACE_FILTER_SIZE] __initdata;
>>
>> static int __init set_ftrace_notrace(char *str)
>> {
>> @@ -2291,6 +2290,7 @@ static int __init set_ftrace_filter(char *str)
>> __setup("ftrace_filter=", set_ftrace_filter);
>>
>> #ifdef CONFIG_FUNCTION_GRAPH_TRACER
>> +static char ftrace_graph_buf[FTRACE_FILTER_SIZE] __initdata;
>> static int __init set_graph_function(char *str)
>> {
>> strlcpy(ftrace_graph_buf, str, FTRACE_FILTER_SIZE);
>>
>
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/