Re: [PATCH 1/4] powerpc: Add Kconfig dependency for PCI_MSI asneeded by XICS

From: Michael Ellerman
Date: Tue Nov 17 2009 - 07:40:20 EST


On Tue, 2009-11-17 at 12:07 +0000, Mel Gorman wrote:
> It's possible to set CONFIG_XICS without CONFIG_PCI_MSI. When that
> happens, the kernel fails to build with
>
> arch/powerpc/platforms/built-in.o: In function `.xics_startup':
> xics.c:(.text+0x12f60): undefined reference to `.unmask_msi_irq'
> make: *** [.tmp_vmlinux1] Error 1
>
> This patch adds the dependency in KConfig.

Actually we should ifdef the code instead, XICS doesn't require MSI -
that code chunk just needs to be conditional.

cheers

Attachment: signature.asc
Description: This is a digitally signed message part