Re: [PATCH] ftdi_sio: Keep going when write errors areencountered.

From: Greg KH
Date: Tue Nov 17 2009 - 22:56:17 EST


On Tue, Nov 17, 2009 at 07:10:48PM -0800, Eric W. Biederman wrote:
>
> The use of urb->actual_length to update tx_outstanding_bytes
> implicitly assumes that the number of bytes actually written is the
> same as the number of bytes we tried to write. On error that
> assumption is violated so just use transfer_buffer_length the number
> of bytes we intended to write to the device.
>
> If an error occurs we need to fall through and call
> usb_serial_port_softint to wake up processes waiting in
> tty_wait_until_sent.
>
> Signed-off-by: Eric W. Biederman <ebiederm@xxxxxxxxxxxxxxxxxx>

Nice job, thanks for debugging this. I'll go queue it up.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/