Re: [PATCH 1/1] Add all TWL4030 regulators to Regulator framework

From: Juha Keski-Saari
Date: Thu Nov 19 2009 - 02:05:01 EST


ext Mark Brown wrote:
On Wed, Nov 18, 2009 at 04:36:09PM +0200, Eduardo Valentin wrote:

But maybe these VINT* should be set as always_on in twl4030-regulator driver?

Can they support any external load at all? If not then it would make
sense for the chip driver to at least provide a default set of
constraints for them rather than forcing all the machine drivers to do
it manually.

From the TRM it appears that the max current output values are as follows

VINTANA1 - 30mA
VINTANA2 - 250mA
VINTDIG - 100mA

Theoretically they may be able to support external load depending on your machine configuration but still I think providing constraints for them in the chip driver could be a good idea since the "always-on" limitation is imposed by the chip and not the machine. Without these three supplies the TWL does not function properly, if at all. Also worth noting is that the current implementation of RegulatorFW doesn't appear to be able to turn these supplies off (comparing TWL register content with framework status).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/