Re: [PATCH 4/5] pata: Update experimental tags

From: Jeff Garzik
Date: Thu Nov 19 2009 - 16:38:49 EST


On 11/18/2009 02:56 PM, Bartlomiej Zolnierkiewicz wrote:
On Wednesday 18 November 2009 20:07:07 Bartlomiej Zolnierkiewicz wrote:
On Wednesday 18 November 2009 19:41:25 Alan Cox wrote:
Maybe they are 'stable' but when it comes to features they are behind hpt366
(i.e. they lack PCI PM), which is also much cleaner than your drivers, easier
to understand and much smaller..

37x and 3xn lack PCI PM. Added to the TODO list.

The smaller size is a bit questionable given its mostly comments, and
three drivers versus one.

I wonder what you find 'questionable' in the numbers given..

BTW we can immediately reclaim 300 LOC by simply merging drivers back..

Merging drivers is a big pain for distributions and end users, even with the new module_alias facility.

Absent stronger justification, libata remains with separate drivers, even if that means some code duplication.

Jeff



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/