Re: [PATCH v2] k10temp: temperature sensor for AMD Family 10h/11hCPUs

From: Clemens Ladisch
Date: Fri Nov 20 2009 - 06:57:01 EST


Jean Delvare wrote:
> On Fri, 20 Nov 2009 11:47:51 +0100, Clemens Ladisch wrote:
> > v2: Erratum 319 now results in a warning, not an error, because it cannot
> > be reliably detected; Serge Belyshev reports that his CPU sensor works.
>
> Nack. Unreliable sensors -> the default must be to NOT bind to these
> CPUs. ... Otherwise your driver will _never_ make it into the
> kernel tree.

Then how did the k8temp driver make it into the kernel tree? :-)

> Feel free to provide a way to force the bind to happen (and still
> print a big fat warning that this is a very bad idea), but do NOT make
> it the default.

Okay, I'll add a force parameter.
I'd guess k8temp should get the same?


Best regards,
Clemens
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/