Re: [PATCH] ixgbe: move tc variable to CONFIG_IXGBE_DCB

[Jeff Kirsher]

On Fri, Nov 20, 2009 at 06:02, Jaswinder Singh Rajput
<jaswinder@xxxxxxxxxx> wrote:
>
> tc is required by CONFIG_IXGBE_DCB.
> This also fixes compilation warning:
>
> Âdrivers/net/ixgbe/ixgbe_main.c: In function âixgbe_tx_is_pausedâ:
> Âdrivers/net/ixgbe/ixgbe_main.c:245: warning: unused variable âtcâ
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@xxxxxxxxx>
> ---
> Âdrivers/net/ixgbe/ixgbe_main.c | Â Â2 +-
> Â1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
> index ebcec30..61a02ce 100644
> --- a/drivers/net/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ixgbe/ixgbe_main.c
> @@ -242,11 +242,11 @@ static void ixgbe_unmap_and_free_tx_resource(struct ixgbe_adapter *adapter,
> Âstatic inline bool ixgbe_tx_is_paused(struct ixgbe_adapter *adapter,
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â struct ixgbe_ring *tx_ring)
> Â{
> - Â Â Â int tc;
> Â Â Â Âu32 txoff = IXGBE_TFCS_TXOFF;
>
> Â#ifdef CONFIG_IXGBE_DCB
> Â Â Â Âif (adapter->flags & IXGBE_FLAG_DCB_ENABLED) {
> + Â Â Â Â Â Â Â int tc;
> Â Â Â Â Â Â Â Âint reg_idx = tx_ring->reg_idx;
> Â Â Â Â Â Â Â Âint dcb_i = adapter->ring_feature[RING_F_DCB].indices;
>
> --
> 1.6.5.3
>
>
> --

I just submitted a patch to fix this.  So NAK.

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/