Re: [PATCH] ixgbe: move tc variable to CONFIG_IXGBE_DCB

From: Jeff Kirsher
Date: Fri Nov 20 2009 - 14:17:00 EST


On Fri, Nov 20, 2009 at 11:13, David Miller <davem@xxxxxxxxxxxxx> wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx>
> Date: Fri, 20 Nov 2009 06:24:21 -0800
>
>> On Fri, Nov 20, 2009 at 06:02, Jaswinder Singh Rajput
>> <jaswinder@xxxxxxxxxx> wrote:
>>>
>>> tc is required by CONFIG_IXGBE_DCB.
>>> This also fixes compilation warning:
>>>
>>> Âdrivers/net/ixgbe/ixgbe_main.c: In function âixgbe_tx_is_pausedâ:
>>> Âdrivers/net/ixgbe/ixgbe_main.c:245: warning: unused variable âtcâ
>>>
>>> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@xxxxxxxxx>
> Â...
>> I just submitted a patch to fix this. ÂSo NAK.
>
> But his is much cleaner that your's, less ifdefs. ÂI think we
> should therefore use Jasdinder's version.
>
>

:) That is fine. The end result is the same.

Acked-by: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx>

--
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/