Re: [PATCH] perf: use default compiler mode by default

From: Ingo Molnar
Date: Mon Nov 23 2009 - 01:56:14 EST



* Arjan van de Ven <arjan@xxxxxxxxxxxxx> wrote:

> On Sun, 22 Nov 2009 14:13:35 +0200
> "Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote:
>
> > gcc with no flags typically is a sane default for systems to use, and
> > looking at the running kernel is probably broken for cross-builds
> > anyway, so let's not do this. Add EXTRA_CFLAGS so that users can
> > override default gcc mode if they want to.
>
> yes please; current perf breaks if you compile it in a 32 bit chroot
> on a 64 bit system....

ok - applied the patch with your ack.

I'd still like to hear back from Paulus whether PowerPC is affected
negatively - IIRC it was PowerPC where we got the -m64 from originally.

Thanks,

Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/