[PATCH] perf_events: fix bogus copy_to_user() in perf_event_read_group()

From: Stephane Eranian
Date: Mon Nov 23 2009 - 11:36:32 EST


   ÂWhen using an event group, the value and id for non leaders events were
   Âwrong due to invalid offset into the outgoing buffer.

   ÂSigned-off-by: Stephane Eranian <eranian@xxxxxxxxxx>

---
Âperf_event.c | Â Â2 +-
Â1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/perf_event.c b/kernel/perf_event.c
index 0b0d5f7..8306127 100644
--- a/kernel/perf_event.c
+++ b/kernel/perf_event.c
@@ -1826,7 +1826,7 @@ static int perf_event_read_group(struct perf_event *event,

       Âsize = n * sizeof(u64);

- Â Â Â Â Â Â Â if (copy_to_user(buf + size, values, size)) {
+ Â Â Â Â Â Â Â if (copy_to_user(buf + ret, values, size)) {
           Âret = -EFAULT;
           Âgoto unlock;
       Â}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/