Re: drivers/dma/ipu/ipu_idmac.c: use resource_size()

From: Guennadi Liakhovetski
Date: Mon Nov 23 2009 - 13:20:30 EST


On Mon, 23 Nov 2009, H Hartley Sweeten wrote:

> Use resource_size() for ioremap.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
> Cc: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>

Acked-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>

>
> ---
>
> diff --git a/drivers/dma/ipu/ipu_idmac.c b/drivers/dma/ipu/ipu_idmac.c
> index 9a5bc1a..bfa2126 100644
> --- a/drivers/dma/ipu/ipu_idmac.c
> +++ b/drivers/dma/ipu/ipu_idmac.c
> @@ -1771,16 +1771,14 @@ static int __init ipu_probe(struct platform_device *pdev)
> ipu_data.irq_fn, ipu_data.irq_err, ipu_data.irq_base);
>
> /* Remap IPU common registers */
> - ipu_data.reg_ipu = ioremap(mem_ipu->start,
> - mem_ipu->end - mem_ipu->start + 1);
> + ipu_data.reg_ipu = ioremap(mem_ipu->start, resource_size(mem_ipu));
> if (!ipu_data.reg_ipu) {
> ret = -ENOMEM;
> goto err_ioremap_ipu;
> }
>
> /* Remap Image Converter and Image DMA Controller registers */
> - ipu_data.reg_ic = ioremap(mem_ic->start,
> - mem_ic->end - mem_ic->start + 1);
> + ipu_data.reg_ic = ioremap(mem_ic->start, resource_size(mem_ic));
> if (!ipu_data.reg_ic) {
> ret = -ENOMEM;
> goto err_ioremap_ic;
>

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/