Re: linux-next: percpu tree build warning

From: Rusty Russell
Date: Wed Nov 25 2009 - 06:14:19 EST


On Wed, 25 Nov 2009 09:20:04 pm Ingo Molnar wrote:
> If yes then that needs to be fixed in the percpu tree. per-cpu variables
> used to have a __per_cpu prefix and that should be maintained - the two
> namespaces are obviously separate on the logical space, so they should
> never overlap in the implementational space either.

No, we've been through this.

sparse annotations replace the per_cpu prefix now per-cpu vars can be used
withn other than per-cpu ops (ie. their address can be usefully taken).

The prefix crutch predated sparse. And it was certainly never supposed to
let people write confusing and crap code like this.

Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/