Re: MODULE_DEVICE_TABLE(isapnp, ...) does nothing

From: Kay Sievers
Date: Wed Nov 25 2009 - 10:25:47 EST


On Wed, Nov 25, 2009 at 15:42, Matthieu CASTET <castet.matthieu@xxxxxxx> wrote:
> Kay Sievers <kay.sievers <at> vrfy.org> writes:
>>
>> No, we don't even have proper modaliases for the pnp bus
>> (/sys/bus/pnp) and the alias string for pnp in the modules have a
>> broken and unfixable format. PNP autoloading is all handled by the
>> acpi modaliases these days. This is the first time in years I hear
>> anybody asking for hotplug setups of plain old pnp devices. :)
>>
> The naming is really bad. This as nothing to do with acpi : pnp and pnp_cards
> entries are duplicated to another naming. And this should work on system
> without
> acpi.
> This should have been named to pnp2 or something like that.

I don' think there is anything like a second version, it's just that
acpi handles the same pnp ids natively, so we added (non-broken)
matches for it, which works properly on almost all current boxes. If
someone wants to finally fix pnp and get proper modalias working, the
acpi alias generation in the pnp modules can be reverted without
trouble.

> Now I don't see why isapnp_device_id and pnp_card_device_id can't be merged
> together.
>
> For example most of alsa isa card use pnp_card_device_id and not
> isapnp_device_id.

It's just that nobody really cared, I guess. I wouldn't be surprised,
if this is just another round of "discussion" like we had so many
about this topic the past years, and nothing will happen to
pnp/isapnp. :)

Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/