Re: [PATCH] vmscan: do not evict inactive pages when skipping anactive list scan

[Rik van Riel]

On 11/25/2009 09:50 PM, KOSAKI Motohiro wrote:
> > -	if (lru == LRU_ACTIVE_ANON&&  inactive_anon_is_low(zone, sc)) {
> > -		shrink_active_list(nr_to_scan, zone, sc, priority, file);
> > +	if (lru == LRU_ACTIVE_ANON) {
> > +		if (inactive_file_is_low(zone, sc))
> >      
> This inactive_file_is_low() should be inactive_anon_is_low().
> cut-n-paste programming often makes similar mistake. probaby we need make
> more cleanup to this function.
>
> How about this? (this is incremental patch from you)
>
>
>    
Doh!  Nice catch...
> Signed-off-by: KOSAKI Motohiro<kosaki.motohiro@xxxxxxxxxxxxxx>
>
>    
Reviewed-by: Rik van Riel <riel@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/