[PATCH] x86/alternatives: check replacementlen <= instrlen at build time

[Jan Beulich]

Having run into the run-(boot-)time check a couple of times lately, I
finally took time to find a build-time check so that one doesn't need
to analyze the register/stack dump and resolve this (through manual
lookup in vmlinux) to the offending construct. The assembler will emit
a message like "Error: value of <num> too large for field of 1 bytes
at <offset>", which while not pointing out the source location still
makes analysis quite a bit easier.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

---
 arch/x86/include/asm/alternative.h     |    1 +
 1 files changed, 1 insertion(+)

--- linux-2.6.32-rc8/arch/x86/include/asm/alternative.h
+++ 2.6.32-rc8-x86-alternative/arch/x86/include/asm/alternative.h
@@ -84,6 +84,7 @@ static inline void alternatives_smp_swit
       "	 .byte " __stringify(feature) "\n"	/* feature bit     */	\
       "	 .byte 662b-661b\n"			/* sourcelen       */	\
       "	 .byte 664f-663f\n"			/* replacementlen  */	\
+      "	 .byte 0xff + (664f-663f) - (662b-661b)\n" /* rlen <= slen */	\
       ".previous\n"							\
       ".section .altinstr_replacement, \"ax\"\n"			\
       "663:\n\t" newinstr "\n664:\n"		/* replacement     */	\



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/