Re: [RFC][PATCH 4/4] vmscan: vmscan don't use pcp list

From: Christoph Lameter
Date: Fri Nov 27 2009 - 14:25:48 EST


On Fri, 27 Nov 2009, KOSAKI Motohiro wrote:

> patch series, but Christoph mentioned simple bypass pcp instead.
> I made it. I'd hear Christoph and Mel's mention.

Ah. good.

> + kmemcheck_free_shadow(page, 0);
> +
> + if (PageAnon(page))
> + page->mapping = NULL;
> + if (free_pages_check(page)) {
> + /* orphan this page. */
> + list_del(&page->lru);
> + continue;
> + }
> + if (!PageHighMem(page)) {
> + debug_check_no_locks_freed(page_address(page),
> + PAGE_SIZE);
> + debug_check_no_obj_freed(page_address(page), PAGE_SIZE);
> + }
> + arch_free_page(page, 0);
> + kernel_map_pages(page, 1, 0);
> +
> + local_irq_save(flags);
> + if (unlikely(wasMlocked))
> + free_page_mlock(page);
> + local_irq_restore(flags);

The above looks like it should be generic logic that is used elsewhere?
Create a common function?


Rest looks good to me...

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/