Re: [Bug 14658] Regression in efi.c

[indexer]

Feng, Peter

I decided to go back a few versions and check out if there any previous 
bugs, and upon bisecting i found this one

commit 37ba7ab5e33cebc25c68fffe33e9f21e7c2014e8
Author: H. Peter Anvin <hpa@xxxxxxxxx>
Date: Mon May 11 15:56:08 2009 -0700

x86, boot: make kernel_alignment adjustable; new bzImage fields

Make the kernel_alignment field adjustable; this allows us to set it
to a large value (intended to be 16 MB to avoid ZONE_DMA contention,
memory holes and other weirdness) while a smart bootloader can still
force a loading at a lesser alignment if absolutely necessary.

Also export pref_address (preferred loading address, corresponding to
the link-time address) and init_size, the total amount of linear
memory the kernel will require during initialization.

[ Impact: allows better kernel placement, gives bootloader more info ]

Signed-off-by: H. Peter Anvin <hpa@xxxxxxxxx>

arch/x86/boot/compressed/head_32.S | 7 +++++--
arch/x86/boot/compressed/head_64.S | 14 ++++++++++----
arch/x86/boot/header.S | 15 +++++++++++++--
arch/x86/include/asm/boot.h | 15 +++++++++++++++
arch/x86/kernel/asm-offsets_32.c | 1 +
arch/x86/kernel/asm-offsets_64.c | 1 +
6 files changed, 45 insertions(+), 8 deletions(-)


This seems to stop efi booting as well on x86_64. I have also been able 
to recently test this on a gen 4 macbook pro as well as my own gen 5 to 
make sure it is not an issue specific to this model.

William

Tang, Feng wrote:
> William,
>
> You've confirmed that apply commit 772be899b "x86: Make EFI RTC function depend
> on 32bit again" right after 7bd867dfb "x86: Move get/set_wallclock to 
> x86_platform_ops" will get a bootable kernel.
>
> Then, one debug method may be use "git-rebase -i" to move commit 772be899b right after 
> 7bd867dfb, and do the bisect from there on. 
>
> Thanks,
> Feng
>   
> > -----Original Message-----
> > From: indexer [mailto:indexer@xxxxxxxxxxxxxxxx]
> > Sent: 2009å11æ25æ 17:43
> > To: Tang, Feng
> > Cc: LKML
> > Subject: Re: [Bug 14658] Regression in efi.c
> >
> > Feng tang
> >
> > I have just tested and applied that correction, and it resulted in a
> > working system. I dont really know where to go from here so any advice
> > would be appreciated.
> >
> > William
> >     
> Nååéçyîæbçîåvèï)è{.nï+åî{çèzXÐæå}îèçï&j:+våïçèzZ+âï+zfïçæîååiïîzïçãï?æçï&ï)æfæ^jèyîå@Açåï0éhïéi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/