Re: [PATCH] nconfig v7

From: Michal Marek
Date: Mon Nov 30 2009 - 09:40:31 EST


On 25.11.2009 11:28, nir.tzachar@xxxxxxxxx wrote:
> Hello.
>
> Attached bellow is version 7 of nconfig, an ncurses based replacement for
> menuconfig. After a thorough overhaul, addressing all concerns raised in the
> past by users on these lists, I would be happy if this version is favorably
> considered for inclusion.
>
> Major changes since version 6:
>
> 1) un-selectable menu items have 'XXX' before them, to indicate the fact.
> 2) there are three separate help menus: main help (bound to F1), symbol help
> (bound to F2 and 'h') and short instructions (bound to F3).

Hi Nir,

I tried it a few times, it's nice :). I get a few warnings about missing
prototypes when compiling it:
HOSTCC scripts/kconfig/nconf.gui.o
scripts/kconfig/nconf.gui.c:23: warning: no previous prototype for
âset_normal_colorsâ
scripts/kconfig/nconf.gui.c:68: warning: no previous prototype for
ânormal_color_themeâ
scripts/kconfig/nconf.gui.c:100: warning: no previous prototype for
âno_colors_themeâ
HOSTCC scripts/kconfig/nconf.o
scripts/kconfig/nconf.c:455: warning: no previous prototype for
âprocess_special_keysâ
scripts/kconfig/nconf.c:487: warning: no previous prototype for
âget_next_hotâ
scripts/kconfig/nconf.c:506: warning: no previous prototype for âcanbhotâ
scripts/kconfig/nconf.c:514: warning: no previous prototype for âis_hotâ
scripts/kconfig/nconf.c:522: warning: no previous prototype for âmake_hotâ
scripts/kconfig/nconf.c:582: warning: no previous prototype for âitem_makeâ
scripts/kconfig/nconf.c:626: warning: no previous prototype for
âitem_add_strâ
scripts/kconfig/nconf.c:656: warning: no previous prototype for âitem_tagâ
scripts/kconfig/nconf.c:668: warning: no previous prototype for
âcurses_item_indexâ
scripts/kconfig/nconf.c:673: warning: no previous prototype for âitem_dataâ
scripts/kconfig/nconf.c:684: warning: no previous prototype for
âitem_is_tagâ
scripts/kconfig/nconf.c:691: warning: no previous prototype for
âset_config_filenameâ

These probably can be static. Oh, and when I suspend the program with
Ctrl-Z, resume with 'fg' and hit an arrow key, the escape sequence is
interpreted as a genuine ESC and it either jumps one menu level above or
wants to exit the program. It happens to me both in xterm and
gnome-terminal, ncurses version is 5.6. Can you see it as well or is
there something broken on my side?

Other than that, I found no issues so far (except for the not really
readable shortcut nOtation, but you say it's hard to fix, so let's
forget about it for now). I'll use it a bit more and have a look at the
code. For now, it is in git://repo.or.cz/linux-kbuild.git#for-review as is.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/