Re: [PATCH 2/2] perf timechart: Remove open-coded event parsingcode

[Arjan van de Ven]

On Tue, 01 Dec 2009 14:05:16 +0800
Li Zefan <lizf@xxxxxxxxxxxxxx> wrote:
> -		size = 8;
> +	if (!(sample_type & PERF_SAMPLE_RAW)) {
> +		fprintf(stderr,
> +			"No trace sample to read. Did you call perf
> record "
> +			"without -R?");
> +		return -1;
>  	}

while I like your cleanup... I am not so sure this printk makes sense
whatsoever.... the user did not use "perf record" to get here...



-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/