Re: [PATCH] slow-work: Fix build bug in the !CONFIG_MODULES case

[Stephen Rothwell]

Hi Ingo,

On Tue, 1 Dec 2009 07:56:05 +0100 Ingo Molnar <mingo@xxxxxxx> wrote:
>
> these slow-work changes have introduced a new !CONFIG_MODULES build bug 
> on x86 (and all other architectures i suspect):

Thanks for the heads up!

> From: Ingo Molnar <mingo@xxxxxxx>
> Date: Tue, 1 Dec 2009 07:47:52 +0100
> Subject: [PATCH] slow-work: Fix build bug in the !CONFIG_MODULES case
> 
> Commit 3bde31a ("SLOW_WORK: Allow a requeueable work item to sleep till
> the thread is needed") broke the !CONFIG_MODULES build by relying on
> variables that are only available (and only make sense) with module
> support enabled. Fix it.
> 
> Cc: David Howells <dhowells@xxxxxxxxxx>
> Cc: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Ingo Molnar <mingo@xxxxxxx>

I have applied this to linux-next for today, just so people don't waste
their time finding this breakage again.

-- 
Cheers,
Stephen Rothwell                    sfr@xxxxxxxxxxxxxxxx
http://www.canb.auug.org.au/~sfr/

Attachment: pgp00000.pgp
Description: PGP signature