Re: [Patch] selinux: remove an unreachable line
From: Cong Wang
Date: Tue Dec 01 2009 - 03:28:56 EST
Joe Perches wrote:
On Tue, 2009-12-01 at 02:41 -0500, Amerigo Wang wrote:
This line is unreachable, remove it.
[]
diff --git a/security/selinux/ss/mls.c b/security/selinux/ss/mls.c
index b5407f1..a2f1034 100644
--- a/security/selinux/ss/mls.c
+++ b/security/selinux/ss/mls.c
@@ -544,7 +544,6 @@ int mls_compute_sid(struct context *scontext,
default:
return -EINVAL;
}
- return -EINVAL;
}
I think it's better to remove the default case.
This is totally a personal taste, I think.
Either is OK. James, any comments?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/