Re: warning: massive change to conditional coding style in net?

From: David Miller
Date: Tue Dec 01 2009 - 18:28:53 EST


From: William Allen Simpson <william.allen.simpson@xxxxxxxxx>
Date: Tue, 01 Dec 2009 12:56:40 -0500

> Heck, changes to comments!

Comments help people understand your code. Long after you're gone and
no longer around, other people will need to read your code, maintain
it, and fix bugs in it.

That's why well written and properly formatted comments are important.

Again, nobody is picking on your specifically, everyone goes through
this review process. What is unique about you is that you're the only
one who throws rotten tomatoes back at the reviewers instead of simply
fixing up your patch set and resubmitting.

If the changes requested are so simple and trivial, then it should
take you but a few minutes to respin your patches with the fixes
included.

It definitely takes you more effort to write all of these angry
emails, but how you spend your time is your choice.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/