Re: [PATCH v2] mm: Introduce coredump parameter structure

[Ingo Molnar]

* Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:

> Andrew Morton wrote:
> >On Sat, 28 Nov 2009 23:41:19 -0500
> >Masami Hiramatsu<mhiramat@xxxxxxxxxx>  wrote:
> >
> >>Introduce coredump parameter data structure (struct coredump_params)
> >>for simplifying binfmt->core_dump() arguments.
> >>
> >>Changes in v2:
> >>    - Don't remove DUMP_WRITE() macro.
> >
> >What is the reason for this change?
> >
> >Please always include both the "what" and the "why" in changelog text.
> 
> I see.

I think Andrew wanted to see a longer explanation about precisely what 
we need for these tracepoints and what the various specific usecases are 
to utilize it.

I.e. a basic cost/benefit analysis is needed. By looking at the patch we 
can see the cost - but you have to counter-balance that with enough 
stuff in the 'benefits' column of the equation.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/