Re: [PATCH] NOMMU: use copy_*_user_page() in access_process_vm()

[Jie Zhang]

On 12/02/2009 10:36 PM, David Howells wrote:
> Mike Frysinger<vapier@xxxxxxxxxx>  wrote:
>
> > -			len -= copy_to_user((void *) addr, buf, len);
> > +			copy_to_user_page(vma, NULL, NULL,
> > +					  (void *) addr, buf, len);
> >   		else if (!write&&  vma->vm_flags&  VM_MAYREAD)
> > -			len -= copy_from_user(buf, (void *) addr, len);
> > +			copy_from_user_page(vma, NULL, NULL,
> > +					    buf, (void *) addr, len);
>
> Hmmm...  With this, len isn't updated anymore, and so it alters the return
> value of access_process_vm(), and means ptrace_readdata() won't now return
> -EIO under some circumstances where it used to.  I'm not sure that matters,
> though.
This keeps access_process_vm() in nommu.c align with the one in 
memory.c. If this does really matter, someone or me can write another 
patch to take care of it for both MMU and !MMU later.


Jie
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/