Re: [PATCH 21/24] cgroup: define empty css_put() when !CONFIG_CGROUPS

[Paul Menage]

On Tue, Dec 1, 2009 at 7:12 PM, Wu Fengguang <fengguang.wu@xxxxxxxxx> wrote:
> --- linux-mm.orig/include/linux/cgroup.h        2009-11-02 10:18:41.000000000 +0800
> +++ linux-mm/include/linux/cgroup.h     2009-11-02 10:26:22.000000000 +0800
> @@ -581,6 +581,9 @@ static inline int cgroupstats_build(stru
>        return -EINVAL;
>  }
>
> +struct cgroup_subsys_state;
> +static inline void css_put(struct cgroup_subsys_state *css) {}
> +
>  #endif /* !CONFIG_CGROUPS */

This doesn't sound like the right thing to do - if !CONFIG_CGROUPS,
then the code shouldn't be able to see a css structure to pass to this
function.

Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/